Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove control dependency #33092

Closed
adeebshihadeh opened this issue Jul 26, 2024 · 2 comments
Closed

Remove control dependency #33092

adeebshihadeh opened this issue Jul 26, 2024 · 2 comments
Labels
bounty cleanup good first issue Feasible for new contributers

Comments

@adeebshihadeh
Copy link
Contributor

It's just used in one place in one test:

ss = StateSpace(A, B, np.eye(2), np.zeros((2, 2)))

The goal is to replace it with pure Python (and some numpy).

uv pip tree for control:

control v0.10.0
├── numpy v1.26.4
├── scipy v1.14.0
│   └── numpy v1.26.4
└── matplotlib v3.9.1
    ├── contourpy v1.2.1
    │   └── numpy v1.26.4
    ├── cycler v0.12.1
    ├── fonttools v4.53.1
    ├── kiwisolver v1.4.5
    ├── numpy v1.26.4
    ├── packaging v24.1
    ├── pillow v10.4.0
    ├── pyparsing v3.1.2
    └── python-dateutil v2.9.0.post0
        └── six v1.16.0
@adeebshihadeh adeebshihadeh added good first issue Feasible for new contributers bounty cleanup labels Jul 26, 2024
@Jaishree2310
Copy link

Hey @adeebshihadeh, Can you please assign this issue to me?
Thank you!

@coderight1
Copy link

Hi @adeebshihadeh ,
I am very interested in working on this issue, and I have thoroughly reviewed the codebase. I am confident in my ability to resolve this issue. Here’s my approach:

  1. State-Space Replacement: I will implement a custom StateSpace class using pure Python and NumPy to replace the dependency on the control library. This class will handle continuous and discrete-time systems, ensuring compatibility with the existing codebase.
  2. Integration and Testing: I will integrate the new StateSpace class into test_vehicle_model.py, replacing the current usage of the control library. I will ensure that all existing tests pass and maintain the functionality of the original implementation.

Given my experience and this detailed plan, I am confident in my ability to address this issue effectively.

Could you please assign this issue to me?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty cleanup good first issue Feasible for new contributers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants