Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't timeout if the runner is slow to pick up the job #1521

Merged
merged 24 commits into from
Nov 24, 2024

Conversation

maxime-desroches
Copy link
Contributor

No description provided.

@maxime-desroches maxime-desroches marked this pull request as draft November 23, 2024 03:36
@maxime-desroches maxime-desroches marked this pull request as ready for review November 23, 2024 06:20
@@ -51,3 +56,7 @@ jobs:
restore-keys: |
${{ runner.os }}-pre-commit-
- run: uv run pre-commit run --all
- uses: ./.github/workflows/timeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other actions have something like a "Post checkout" that runs at the end. can we do that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only possible with JS actions. Created a really simple one here: https://github.com/commaai/timeout
We now only have to do this once:

- uses: commaai/timeout@v1

or to specify a timeout other than 60 seconds:

- uses: commaai/timeout@v1
  with:
    timeout: 20

@maxime-desroches maxime-desroches merged commit 21910a8 into master Nov 24, 2024
4 checks passed
@maxime-desroches maxime-desroches deleted the timeout_ci branch November 24, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants