Toyota: Add SECOC longitudinal control #1385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Oct 18, 2024
chrispypatt
force-pushed
the
secoc-long
branch
2 times, most recently
from
745b551
to
848f074
Compare
chrispypatt
force-pushed
the
secoc-long
branch
from
848f074
to
ce6b289
Compare
chrispypatt
force-pushed
the
secoc-long
branch
from
c8afe63
to
96c184f
Compare
chrispypatt
force-pushed
the
secoc-long
branch
from
96c184f
to
490067a
Compare
3 tasks
jyoung8607
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Long term I'd like to clean up the SecOC message wrapping convention, but that's a separate refactor that we don't need to get into for this PR.
For development purposes we've gotten away with setting the accel value in both ACC control messages, but before we merge we need to match stock actuation behavior: always set zero/inactive acceleration in ACC_CONTROL, and only send the true accel in ACC_CONTROL_2. There are checks in commaai/panda#2072 to ensure this correct behavior.
Aside from that, LGTM.
jyoung8607
reviewed
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openpilotLongitudinalControldisableThis will be accompanied by this related panda safety PR: commaai/panda#2061