CANParser: filter CAN messages by bus and addresses #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
changed the title
deanlee
force-pushed
the
parser_filter_strings
branch
2 times, most recently
from
6c9cc58
to
13b83ea
Compare
deanlee
changed the title
deanlee
force-pushed
the
parser_filter_strings
branch
3 times, most recently
from
7fa0a18
to
098d170
Compare
deanlee
force-pushed
the
parser_filter_strings
branch
from
098d170
to
b2f189d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filtering for CAN messages based on the bus and addresses that the CANParser specifically cares about.
Instead of converting and copying all incoming messages from Python to C++ , we now only parse and copy those with relevant addresses to the c++
CanFramevector. This reduces the overhead from unnecessary message processing, lowering CPU and memory usage while enhancing overall performance and efficiency.