Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARS.md: Added a year column #1361

Closed
wants to merge 2 commits into from
Closed

Conversation

ugtthis
Copy link

@ugtthis ugtthis commented Oct 9, 2024

  • Easier to find the relevant year when there is a separate column
  • Comma body and Tesla models didn’t have a year so I added “-“ to represent the blank year

How I verified changes:

  • Scanned through the diff multiple times making sure intended changes were made accurately
  • Used chat gpt to compare random lines of the old table with the new table to make sure I didn’t change a year to a different year by accident



Vid comparing changes

comparing-table-changes.mp4

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@ugtthis ugtthis closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant