Only query single route if segmentRange specified (#522)

* fixed issue * removed previous approach * implemented possible fix * fixed issue on login * fixed logical error * update comma-api * stash * fixed driveview not loading * revert all to master * toooooooo messy * clean up * more * add comment --------- Co-authored-by: Shane Smiskol <[email protected]>
commaai · Jul 12, 2024 · 6600dfc · 6600dfc
1 parent 396f0d6
commit 6600dfc
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 12 deletions.
diff --git a/package.json b/package.json
@@ -24,7 +24,7 @@
     "node": ">=16"
   },
   "dependencies": {
-    "@commaai/api": "github:commaai/comma-api#3.1.2",
+    "@commaai/api": "github:commaai/comma-api#3.1.3",
     "@commaai/my-comma-auth": "^1.4.1",
     "@mapbox/mapbox-sdk": "^0.15.3",
     "@material-ui/core": "^1.5.1",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/actions/index.js b/src/actions/index.js
@@ -32,10 +32,18 @@ export function checkRoutesData() {
     const { dongleId } = state;
     const fetchRange = state.filter;
 
-    routesRequest = {
-      req: Drives.getRoutesSegments(dongleId, fetchRange.start, fetchRange.end, state.limit),
-      dongleId,
-    };
+    // if requested segment range not in loaded routes, fetch it explicitly
+    if (state.segmentRange) {
+      routesRequest = {
+        req: Drives.getRoutesSegments(dongleId, undefined, undefined, undefined, `${dongleId}|${state.segmentRange.log_id}`),
+        dongleId,
+      };
+    } else {
+      routesRequest = {
+        req: Drives.getRoutesSegments(dongleId, fetchRange.start, fetchRange.end, state.limit),
+        dongleId,
+      };
+    }
 
     routesRequestPromise = routesRequest.req.then((routesData) => {
       state = getState();
@@ -148,8 +156,6 @@ export function urlForState(dongleId, log_id, start, end, prime) {
 }
 
 function updateTimeline(state, dispatch, log_id, start, end, allowPathChange) {
-  dispatch(checkRoutesData());
-
   if (!state.loop || !state.loop.startTime || !state.loop.duration || state.loop.startTime < start
     || state.loop.startTime + state.loop.duration > end || state.loop.duration < end - start) {
     dispatch(resetPlayback());