-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml #6386
Add pyproject.toml #6386
Conversation
Should there be concern for users not using Comfy-Org/desktop since this would be removing the additional info provided by |
There is definitely a behaviour change, but I don't think there is any extension currently referencing the https://cs.comfy.org/search?q=context:global+comfyui_version&patternType=keyword&sm=0 |
That link requires a login but I'll take your word for it. My concern was more into regards to bug reporting -- users using git (more or less everybody currently, except for early desktop beta adopters) who may report bugs inbetween stable releases and may mistakenly report the incorrect version number by reporting only what's shown in the UI -- but that can be resolved in other ways. |
Offline discussion with @comfyanonymous:
|
Note: The update action verified to be working on #6404 |
just note: usual approach is to name it |
This PR adds
pyproject.toml
file to track ComfyUI version. Previous method relies on git being installed in the local system and the project is distributed as a git repo, which is not true for https://github.com/Comfy-Org/desktop.After this PR, please update
project.version
each time a new version tag is created. Custom nodes can now dofrom comfyui_version import __version__
to get ComfyUI's version.Some follow-up tasks:
ruff.toml
topyproject.toml
'stools.ruff
sectiondependencies
/optional_dependencies
sections. (When dependency is updated, a new github action will auto generaterequirements.txt
)stable-release.yml
when version in pyproject.toml is changed.Note:
toml
library is added as Python's official support for toml(tomllib
) is added in 3.11.Reference: