RUFFs RET504 rule (unnecessary assignment before return statement)
#6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement) Signed-off-by: bigcat88 <[email protected]>
bigcat88
requested review from
yoland68,
robinjhuang,
huchenlei,
pythongosssss,
ltdrdata,
Kosinkadink,
webfiltered and
comfyanonymous
as code owners
|
I'm not against these types of format rules but they should be introduced gradually not all at once. |
|
If you suggest making a separate PR for each file/pair of files, wouldn't that be spammy in the commit/changelog? If it's only for one RUFF rule per PR, I'm all for it. |
|
I'll close this PR, since it's big, and it's better to start with smaller rules, like this: #6316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff docs regarding this rule.
ruff check . --unsafe-fixes --fixwas performed and then everything was checked to see if it was replaced correctly.If this rule is not needed, please just close the PR (since it affects all files, it will need to be constantly rebased, if not merged, which is lazy).