Lint and fix undefined names (1/N) #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Dec 12, 2024
| @@ -228,9 +228,9 @@ def __init__( | |||
| linear_in = GLU(dim, inner_dim, activation, dtype=dtype, device=device, operations=operations) | |||
| else: | |||
| linear_in = nn.Sequential( | |||
| Rearrange('b n d -> b d n') if use_conv else nn.Identity(), | |||
There was a problem hiding this comment.
Rearrange is not defined in dit.py, I believe it's a misspelling of rearrange from einops.
| @@ -52,7 +54,7 @@ def __init__( | |||
|
|
|||
| if self.use_ema: | |||
| self.model_ema = LitEma(self, decay=ema_decay) | |||
| logpy.info(f"Keeping EMAs of {len(list(self.model_ema.buffers()))}.") | |||
There was a problem hiding this comment.
Replacing logpy with python's built-in logging module. logpy is not used in this project.
| @@ -112,7 +114,7 @@ def __init__( | |||
|
|
|||
| self.encoder: torch.nn.Module = instantiate_from_config(encoder_config) | |||
| self.decoder: torch.nn.Module = instantiate_from_config(decoder_config) | |||
| self.regularization: AbstractRegularizer = instantiate_from_config( | |||
There was a problem hiding this comment.
AbstractRegularizer is not defined in the code. Since it's a type annotation, removing it does not alter any runtime behaviors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first PR that fixes most obvious undefined names errors.