Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NA]: [FE] replace getProjectByName function endpoint; #643

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

aadereiko
Copy link
Contributor

Details

  • using a new endpoint that was provided by the BE;

Issues

Resolves #

Testing

Documentation

@aadereiko aadereiko requested a review from a team as a code owner November 14, 2024 17:11
@aadereiko aadereiko changed the title [NA]: replace getProjectByName function endpoint; [NA]: [FE] replace getProjectByName function endpoint; Nov 14, 2024
{
signal,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aadereiko I have a question: Why request without a signal? That means the request will not be canceled when the hook is destroyed. Am I missing something?

Copy link
Contributor Author

@aadereiko aadereiko Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, automatically, i removed it because of the POST request. brought it back, thanks!

@ferc ferc merged commit 734e9fd into main Nov 15, 2024
1 check passed
@ferc ferc deleted the sashaa/replace_get_project_by_name_hook branch November 15, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants