[OPIK-239] [UX improvements] Add charts of experiment table #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[OPIK-223] [UX improvements] Add grouping by dataset in experiment table
andriidudar
force-pushed
the
andriidudar/OPIK-223-experiments-dashboard
branch
from
90ae0e2
to
0487c5d
Compare
ferc
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Some improvements for next PR:
-
I guess we could avoid this kind of empty charts (dataset with no feedback scores)
-
The feedback scores with
0as value are not displayed in the charts -
Also in another topic, we should start thinking about performance (virtualize the table), the resize of the columns is slow in big tables
| type="natural" | ||
| key={line} | ||
| isAnimationActive={false} | ||
| dataKey={(x) => x.scores[line] || undefined} |
There was a problem hiding this comment.
Why we don't display the 0 data points? Not sure what we're trying to achieve with this || undefined here
There was a problem hiding this comment.
It was some testing code that I forgot to delete, thanks for poining me.
Comment on lines
+202
to
+209
| if (isUndefined(experimentsData)) { | ||
| experimentsData = experimentsCache.current[dataset.id] ?? { | ||
| content: [], | ||
| total: 0, | ||
| }; | ||
| } else { | ||
| experimentsCache.current[dataset.id] = experimentsData; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
OPIK-239 [UX improvements] Add charts of experiment table
OPIK-223 [UX improvements] Add grouping by dataset in experiment table
Issues
Resolves #
Testing
Documentation