Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OPIK-63] [New feature] Add segment to Opik Cloud #201

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

andriidudar
Copy link
Contributor

Details

Issues

Resolves #

Testing

Documentation

@andriidudar andriidudar requested a review from a team as a code owner September 10, 2024 09:03
@robertlacok
Copy link

Small comment for your consideration (but not to block the PR), technical users like ours generally use adblocks with the rate of 30-50%, and adblocks block the segment domain.

We could get much better success if identify and trackEvent methods send the data to our own backend, and the backend sends it to Segment.

A second aspect would be the name of the backend route – if you avoid something like /analytics or /track but rather call it something inconspicuous, you can avoid even more rules in adblocks.

@andriidudar
Copy link
Contributor Author

Small comment for your consideration (but not to block the PR), technical users like ours generally use adblocks with the rate of 30-50%, and adblocks block the segment domain.

We could get much better success if identify and trackEvent methods send the data to our own backend, and the backend sends it to Segment.

A second aspect would be the name of the backend route – if you avoid something like /analytics or /track but rather call it something inconspicuous, you can avoid even more rules in adblocks.

Thanks for your input here. We have the same functionality right now for the main app. So we can change it together in the future

@andriidudar andriidudar merged commit 4fd6400 into main Sep 10, 2024
5 checks passed
@andriidudar andriidudar deleted the andriidudar/segment-analytics branch September 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants