Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NA] Bump version 2.2.6 #143

Merged
merged 3 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
package_dir={"": "src"},
url="https://www.comet.com",
project_urls=project_urls,
version="2.2.5",
version="2.2.6",
zip_safe=False,
license="MIT",
)
5 changes: 4 additions & 1 deletion src/comet_llm/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,10 @@ def init(

kwargs = {key: value for key, value in kwargs.items() if value is not None}

comet_ml.init(**kwargs)
if hasattr(comet_ml, "login"):
comet_ml.login(**kwargs)
else:
comet_ml.init(**kwargs) # deprecated

global _COMET_LLM_CONFIG
# Recreate the Config object to re-read the config files
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def mock_config_dict(patch_module):

def test_init__happyflow(mock_config_dict):
with Scenario() as s:
s.comet_ml.init(
s.comet_ml.login(
api_key="api-key",
workspace="the-workspace",
project_name="the-project"
Expand All @@ -39,7 +39,7 @@ def test_init__happyflow(mock_config_dict):

def test_init__not_set_arguments_not_passed_to_comet_ml_init(mock_config_dict):
with Scenario() as s:
s.comet_ml.init(api_key="api-key")
s.comet_ml.login(api_key="api-key")
# Config object is recreated to re-read the config files
s.config_helper.create_config_instance() >> "new-config"

Expand Down
Loading