Scala 3 without Scala 2.13 toolchain #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
changed the title
unapply is generated differently in Scala 3 creating an invinite loop Replaced the call to unapply to a manual implementation
This was referenced Nov 14, 2023
lolgab
changed the title
uPickle 3 doesn't have a version that supports Scala 3.1, so I'm dropping it's support
lefou
reviewed
Nov 14, 2023
lefou
approved these changes
Nov 15, 2023
|
@alexarchambault @lihaoyi Can I have another review? |
lefou
reviewed
Nov 15, 2023
fastparse doesn't support it anymore
Some modules are cross-compiled to only one Scala 3 version which needs to be the oldest Scala 3 version, otherwise we can't make other modules depend on it. So we run tests by passing the binary version and let mill choose the last available Scala version that matches
This seems to be a bug in mill which doesn't allow to mix modules with different Scala 3 versions. Adding a workaround in the build by overriding a ScalaModule target
1 task
lihaoyi
approved these changes
Nov 16, 2023
|
Looks reasonable to me. If the test suite passes that gives us confidence that nothing broke |
|
-350 lines of code is also very nice, given how gnarly a lot of the deleted code is |
lefou
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Until now Ammonite for Scala 3 was compiled using a mix of the Scala 2.13 and the Scala 3 compiler.
This was great since it allowed us to have Ammonite on Scala 3 before
fastparse,mainargsand other libraries were even supported on Scala 3, or they were not on par with their Scala 2.13 counterpart.Now that the ecosystem has caught up with Scala 3, we can avoid using Scala 2.13 and do everything with Scala 3.
This has the benefit that now all the classpath contains only Scala 3 libraries and we can finally invoke Scala 3 macros in the included libraries like
upickle.Also, the build gets much simpler since we don't have to do tricks to swap dependencies at runtime and manually remove transitive dependencies.
The only dependency that still is on Scala 2.13 is scalameta
common, for which we still force the Scala 3 version of itssourcecodedependency to avoid double dependencies at runtime.uPickle macros on Scala 3
Breaking changes
-crossnaming convention anymore but are just like Scala 2 artifacts except for the_3or_3.x.ysuffixammonite.util.Bindnow depends on typename instead of scala-reflect (which doesn't have a Scala 3 counterpartscala-java8-compatupdated to1.0.2mainargsupdated to0.5.4requestsupdated to0.8.0interp.api.APIHolder.valueis nowfinaltypeOfremoved from Scala 3 API (was not supported already)mainargs.LeftoverPull request: #1383
Fixes: #1250