New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ImportData.ImportType use of sealed #1211

Open

nbauernfeind wants to merge 2 commits into com-lihaoyi:main from nbauernfeind:import_type

Contributor

nbauernfeind commented Aug 24, 2021

The compiler says not all types are covered for this piece of code:

private[this] def onImportData(id: ImportData): Unit = {
  id.importType match {
    case ImportData.Type => onImportDataType(id)
    case ImportData.Term => onImportDataTerm(id)
    case ImportData.TermType =>
      onImportDataType(id)
      onImportDataTerm(id)
  }
}

I believe, that this is just simply from an incorrect usage of Scala's sealed.


          fix ImportData.ImportType use of sealed

e738c89

Contributor Author

nbauernfeind commented Sep 1, 2021

@alexarchambault I would be curious what you think of this PR as well =). Thank you in advance!


          Use constructor param / extend Product & Serializable

37402ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet