Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement support for "Blackmagic Design" camera colour encodings. #793

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
+21,234 −15
Draft

PR: Implement support for "Blackmagic Design" camera colour encodings. #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b8b8bd
Staging current work.
nick-shaw May 19, 2020
c43ae8c
Staging current work.
nick-shaw May 22, 2020
55499eb
Add basic support for Blackmagic colour spaces.
nick-shaw May 27, 2020
42b4b74
Update BMD colour space names to current format.
Mar 12, 2021
652eef5
Improve implementation consistency of "Blackmagic Design" colourspace…
KelSolaar Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,18 +909,24 @@ RGB Colourspaces
'Adobe RGB (1998)',
'Adobe Wide Gamut RGB',
'Apple RGB',
'BMD 46K Film V1',
'BMD 46K Film V3',
'BMD 4K Film V1',
'BMD 4K Film V3',
'BMD Film V1',
'BMD Wide Gamut V4',
'Best RGB',
'Beta RGB',
'CIE RGB',
'Cinema Gamut',
'ColorMatch RGB',
'DaVinci Wide Gamut',
'DCDM XYZ',
'DCI-P3',
'DCI-P3+',
'DJI D-Gamut',
'DRAGONcolor',
'DRAGONcolor2',
'DaVinci Wide Gamut',
'Display P3',
'Don RGB 4',
'ECI RGB v2',
Expand All @@ -933,6 +939,7 @@ RGB Colourspaces
'ITU-R BT.470 - 625',
'ITU-R BT.709',
'Max RGB',
'N-Gamut',
'NTSC (1953)',
'NTSC (1987)',
'P3-D65',
Expand Down Expand Up @@ -960,6 +967,7 @@ RGB Colourspaces
'aces',
'adobe1998',
'prophoto',
'sRGB']

OETFs
*****
Expand Down Expand Up @@ -1009,6 +1017,11 @@ Log Encoding / Decoding
'ACEScct',
'ACESproxy',
'ALEXA Log C',
'Blackmagic 4.6K Film',
'Blackmagic 4K Film',
'Blackmagic Film',
'Blackmagic Pocket 4K Film',
'Blackmagic Pocket 6K Film',
'Canon Log',
'Canon Log 2',
'Canon Log 3',
Expand Down
21 changes: 20 additions & 1 deletion colour/models/rgb/datasets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
from .arri_alexa_wide_gamut import RGB_COLOURSPACE_ALEXA_WIDE_GAMUT
from .best_rgb import RGB_COLOURSPACE_BEST_RGB
from .beta_rgb import RGB_COLOURSPACE_BETA_RGB
from .blackmagic_design import (
RGB_COLOURSPACE_BMD_FILM_V1, RGB_COLOURSPACE_BMD_4K_FILM_V1,
RGB_COLOURSPACE_BMD_4K_FILM_V3, RGB_COLOURSPACE_BMD_46K_FILM_V1,
RGB_COLOURSPACE_BMD_46K_FILM_V3, RGB_COLOURSPACE_BMD_WIDE_GAMUT_V4)
from .cie_rgb import RGB_COLOURSPACE_CIE_RGB
from .canon_cinema_gamut import RGB_COLOURSPACE_CINEMA_GAMUT
from .color_match_rgb import RGB_COLOURSPACE_COLOR_MATCH_RGB
Expand Down Expand Up @@ -74,6 +78,18 @@
RGB_COLOURSPACE_BEST_RGB,
RGB_COLOURSPACE_BETA_RGB.name:
RGB_COLOURSPACE_BETA_RGB,
RGB_COLOURSPACE_BMD_FILM_V1.name:
RGB_COLOURSPACE_BMD_FILM_V1,
RGB_COLOURSPACE_BMD_4K_FILM_V1.name:
RGB_COLOURSPACE_BMD_4K_FILM_V1,
RGB_COLOURSPACE_BMD_4K_FILM_V3.name:
RGB_COLOURSPACE_BMD_4K_FILM_V3,
RGB_COLOURSPACE_BMD_46K_FILM_V1.name:
RGB_COLOURSPACE_BMD_46K_FILM_V1,
RGB_COLOURSPACE_BMD_46K_FILM_V3.name:
RGB_COLOURSPACE_BMD_46K_FILM_V3,
RGB_COLOURSPACE_BMD_WIDE_GAMUT_V4.name:
RGB_COLOURSPACE_BMD_WIDE_GAMUT_V4,
RGB_COLOURSPACE_BT470_525.name:
RGB_COLOURSPACE_BT470_525,
RGB_COLOURSPACE_BT470_625.name:
Expand Down Expand Up @@ -198,7 +214,10 @@
'RGB_COLOURSPACE_ACESCG', 'RGB_COLOURSPACE_ADOBE_RGB1998',
'RGB_COLOURSPACE_ADOBE_WIDE_GAMUT_RGB', 'RGB_COLOURSPACE_ALEXA_WIDE_GAMUT',
'RGB_COLOURSPACE_APPLE_RGB', 'RGB_COLOURSPACE_BEST_RGB',
'RGB_COLOURSPACE_BETA_RGB', 'RGB_COLOURSPACE_BT470_525',
'RGB_COLOURSPACE_BETA_RGB', 'RGB_COLOURSPACE_BMD_FILM_V1',
'RGB_COLOURSPACE_BMD_4K_FILM_V1', 'RGB_COLOURSPACE_BMD_4K_FILM_V3',
'RGB_COLOURSPACE_BMD_46K_FILM_V1', 'RGB_COLOURSPACE_BMD_46K_FILM_V3',
'RGB_COLOURSPACE_BMD_WIDE_GAMUT_V4', 'RGB_COLOURSPACE_BT470_525',
'RGB_COLOURSPACE_BT470_625', 'RGB_COLOURSPACE_BT709',
'RGB_COLOURSPACE_BT2020', 'RGB_COLOURSPACE_CIE_RGB',
'RGB_COLOURSPACE_CINEMA_GAMUT', 'RGB_COLOURSPACE_COLOR_MATCH_RGB',
Expand Down
Loading