Skip to content
Qodana

Merge pull request #170 from colorfulFlames/qodana/quick-fixes-847680… #21

Sign in to view logs

Merge pull request #170 from colorfulFlames/qodana/quick-fixes-847680…

Merge pull request #170 from colorfulFlames/qodana/quick-fixes-847680… #21

Triggered via push March 29, 2024 03:31
@SeveralCirclesSeveralCircles
pushed f70cd96
main
Status Success
Total duration 2m 38s
Artifacts –

qodana.yml

on: push
qodana
2m 28s
qodana
Fit to window
Zoom out
Zoom in

Annotations

105 warnings and 4 notices
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L73
'FileOutputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L118
'FileOutputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L170
'FileInputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/Flames.java#L190
'FileWriter' used without 'try'-with-resources statement
Mismatched read and write of array: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L312
Contents of array `newChannelWords` are written to, but never read
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksCommand.java#L32
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/util/StringUtil.java#L74
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L194
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksContext.java#L35
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/LocaleCommand.java#L45
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksEmbed.java#L55
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/conversations/ConversationEmbed.java#L57
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L124
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/SelectMenuEvent.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/SelectMenuEvent.java#L36
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L50
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/embed/GetAlongEmbed.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/exception/FlamesHandlerEmbed.java#L64
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/GetAlongCommand.java#L26
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/UserContextData.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/exception/handle/ExceptionHandler.java#L21
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/conversations/Conversation.java#L161
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L72
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/GetAlongCommand.java#L29
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/HiCommand.java#L51
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/MessageEvent.java#L90
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L181
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/MessageEvent.java#L68
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/HiCommand.java#L44
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/message/twohundred/UpdatedSettingsEmbed.java#L36
Call to `printStackTrace()` should probably be replaced with more robust logging
Unused import: src/main/java/com/severalcircles/flames/frontend/conversations/SparkVoteMessageContext.java#L13
Unused import `import java.util.ResourceBundle;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/other/GlobalDataEmbed.java#L10
Unused import `import com.severalcircles.flames.util.Ranking;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L9
Unused import `import java.io.IOException;`
Unused import: src/main/java/org/json/XML.java#L29
Unused import `import java.lang.reflect.Method;`
Unused import: src/main/java/com/severalcircles/flames/events/MessageContextEvent.java#L11
Unused import `import net.dv8tion.jda.api.events.interaction.command.UserContextInteractionEvent;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/UserDataEmbed.java#L15
Unused import `import com.severalcircles.flames.util.Emotion;`
Unused import: src/main/java/com/severalcircles/flames/conversations/Conversation.java#L15
Unused import `import com.severalcircles.flames.external.analysis.Analysis;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/WelcomeBackEmbed.java#L10
Unused import `import com.severalcircles.flames.frontend.today.Today;`
Unused import: src/main/java/com/severalcircles/flames/conversations/Conversation.java#L12
Unused import `import com.severalcircles.flames.data.user.UserEntity;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L10
Unused import `import java.util.Arrays;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/UserDataEmbed.java#L22
Unused import `import java.awt.*;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L7
Unused import `import com.severalcircles.flames.data.global.GlobalData;`
Unused assignment: src/main/java/com/severalcircles/flames/events/MessageEvent.java#L42
Variable `nick` initializer `""` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkStartEmbed.java#L41
Variable `embed` initializer `null` is redundant
Unused assignment: src/main/java/org/json/XML.java#L259
Variable `jsonObject` initializer `null` is redundant
Unused assignment: src/main/java/org/json/JSONPointer.java#L163
Variable `prevSlashIdx` initializer `0` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/thanks/ThanksContext.java#L33
The value `FlamesDataManager.readUser(event.getUser())` assigned to `sender` is never used
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkStartEmbed.java#L33
The value `5` assigned to `minutes` is never used
Unused assignment: src/main/java/com/severalcircles/flames/external/ImageSearch.java#L22
Variable `content` initializer `new StringBuffer()` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/data/user/UserConfig.java#L13
Variable `locale` initializer `Locale.getDefault()` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkResultsEmbed.java#L29
Variable `embed` initializer `null` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/data/user/UserEntities.java#L44
Variable `entities` initializer `new HashMap<>()` is redundant
qodana
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L73
'FileOutputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L118
'FileOutputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L170
'FileInputStream' used without 'try'-with-resources statement
AutoCloseable used without 'try'-with-resources: src/main/java/com/severalcircles/flames/Flames.java#L190
'FileWriter' used without 'try'-with-resources statement
Mismatched read and write of array: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L312
Contents of array `newChannelWords` are written to, but never read
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksCommand.java#L32
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/util/StringUtil.java#L74
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L194
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksContext.java#L35
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/LocaleCommand.java#L45
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/thanks/ThanksEmbed.java#L55
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/conversations/ConversationEmbed.java#L57
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L124
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/SelectMenuEvent.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/SelectMenuEvent.java#L36
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L50
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/embed/GetAlongEmbed.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/exception/FlamesHandlerEmbed.java#L64
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/GetAlongCommand.java#L26
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/UserContextData.java#L33
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/exception/handle/ExceptionHandler.java#L21
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/conversations/Conversation.java#L161
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L72
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/GetAlongCommand.java#L29
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/HiCommand.java#L51
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/MessageEvent.java#L90
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/Flames.java#L181
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/events/MessageEvent.java#L68
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/data/user/HiCommand.java#L44
Call to `printStackTrace()` should probably be replaced with more robust logging
Call to 'printStackTrace()': src/main/java/com/severalcircles/flames/frontend/message/twohundred/UpdatedSettingsEmbed.java#L36
Call to `printStackTrace()` should probably be replaced with more robust logging
Unused import: src/main/java/com/severalcircles/flames/frontend/conversations/SparkVoteMessageContext.java#L13
Unused import `import java.util.ResourceBundle;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/other/GlobalDataEmbed.java#L10
Unused import `import com.severalcircles.flames.util.Ranking;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L9
Unused import `import java.io.IOException;`
Unused import: src/main/java/org/json/XML.java#L29
Unused import `import java.lang.reflect.Method;`
Unused import: src/main/java/com/severalcircles/flames/events/MessageContextEvent.java#L11
Unused import `import net.dv8tion.jda.api.events.interaction.command.UserContextInteractionEvent;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/UserDataEmbed.java#L15
Unused import `import com.severalcircles.flames.util.Emotion;`
Unused import: src/main/java/com/severalcircles/flames/conversations/Conversation.java#L15
Unused import `import com.severalcircles.flames.external.analysis.Analysis;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/WelcomeBackEmbed.java#L10
Unused import `import com.severalcircles.flames.frontend.today.Today;`
Unused import: src/main/java/com/severalcircles/flames/conversations/Conversation.java#L12
Unused import `import com.severalcircles.flames.data.user.UserEntity;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L10
Unused import `import java.util.Arrays;`
Unused import: src/main/java/com/severalcircles/flames/frontend/data/user/embed/UserDataEmbed.java#L22
Unused import `import java.awt.*;`
Unused import: src/main/java/com/severalcircles/flames/util/Ranking.java#L7
Unused import `import com.severalcircles.flames.data.global.GlobalData;`
Unused assignment: src/main/java/com/severalcircles/flames/events/MessageEvent.java#L42
Variable `nick` initializer `""` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkStartEmbed.java#L41
Variable `embed` initializer `null` is redundant
Unused assignment: src/main/java/org/json/XML.java#L259
Variable `jsonObject` initializer `null` is redundant
Unused assignment: src/main/java/org/json/JSONPointer.java#L163
Variable `prevSlashIdx` initializer `0` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/thanks/ThanksContext.java#L33
The value `FlamesDataManager.readUser(event.getUser())` assigned to `sender` is never used
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkStartEmbed.java#L33
The value `5` assigned to `minutes` is never used
Unused assignment: src/main/java/com/severalcircles/flames/external/ImageSearch.java#L22
Variable `content` initializer `new StringBuffer()` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/data/user/UserConfig.java#L13
Variable `locale` initializer `Locale.getDefault()` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/frontend/conversations/SparkResultsEmbed.java#L29
Variable `embed` initializer `null` is redundant
Unused assignment: src/main/java/com/severalcircles/flames/data/user/UserEntities.java#L44
Variable `entities` initializer `new HashMap<>()` is redundant
Duplicated code fragment: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L62
Duplicated code
Duplicated code fragment: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L184
Duplicated code
Duplicated code fragment: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L62
Duplicated code
Duplicated code fragment: src/main/java/com/severalcircles/flames/data/FlamesDataManager.java#L184
Duplicated code