Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a waring about unsupported save files #1683

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hexagonrecursion
Copy link
Contributor

@hexagonrecursion hexagonrecursion commented Jul 4, 2024

  • Fixes Crash when loading a level after changing AI code #1623
  • Also addresses some concerns I have about a number of edge cases where public classes or public functions may cause a crash when loading a save if there were changes to the CBot API (even if the changes do not break backward compatibility).

In #1668 (comment) @Emxx52 told me "loading old save files is generally unsupported".

  1. Loading an unsuported crashsave or quicksave now behaves as if there is not save
  2. The -loadsave option also does not recognise a save as valid unless its version is supported
  3. Loading an unsupported save via the save list asks the player to confirm

Note to self: after this is merged I should implement a fix for:

@hexagonrecursion hexagonrecursion changed the title Loading old save files is unsupported Add a waring about unsupported save files Sep 2, 2024
@hexagonrecursion
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when loading a level after changing AI code
1 participant