Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow developers to define #call with arguments for convenience #135

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Target Ruby versions >= 2.1
Required keyword arguments appeared in Ruby 2.1, after the introduction
of keyword arguments in Ruby 2.0.
  • Loading branch information
laserlemon committed Mar 31, 2017
commit 822c2a48618b79620a4d48ef84025c73a9eecaf8
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This should always correspond to the required Ruby version specified in the
# gemspec.
AllCops:
TargetRubyVersion: 2.0
TargetRubyVersion: 2.1

# TODO: What should we do here?
Style/FrozenStringLiteralComment:
Expand Down
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,13 @@ cache: bundler
language: ruby
matrix:
allow_failures:
- rvm: "2.0"
- rvm: ruby-head
notifications:
webhooks:
on_start: always
urls:
- http://buildlight.collectiveidea.com/
rvm:
- "2.0"
- "2.1"
- "2.2"
- "2.3.4"
Expand Down
2 changes: 1 addition & 1 deletion interactor.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
spec.test_files = spec.files.grep(/^spec/)

spec.required_ruby_version = ">= 2.0"
spec.required_ruby_version = ">= 2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A big thank-you for maintaining this value.


spec.add_development_dependency "bundler", "~> 1.9"
spec.add_development_dependency "rake", "~> 10.4"
Expand Down