-
Notifications
You must be signed in to change notification settings - Fork 215
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix new Rubocop failures as of version 0.48.0
This also adds a little bit of organization to the .rubocop.yml configuration file. I also moved some specific rule exceptions out of .rubocop.yml into the code itself.
- Loading branch information
1 parent
3458d12
commit 31efe66
Showing
4 changed files
with
27 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,49 +1,45 @@ | ||
Style/StringLiterals: | ||
EnforcedStyle: double_quotes | ||
# This should always correspond to the required Ruby version specified in the | ||
# gemspec. | ||
AllCops: | ||
TargetRubyVersion: 2.0 | ||
|
||
# TODO: What should we do here? | ||
Style/FrozenStringLiteralComment: | ||
Enabled: false | ||
|
||
# Allow some style changes in specs | ||
Metrics/ModuleLength: | ||
# Allow some style changes in the specs. | ||
AmbiguousBlockAssociation: | ||
Exclude: | ||
- spec/**/* | ||
Metrics/BlockLength: | ||
Exclude: | ||
- spec/**/* | ||
Style/BlockDelimiters: | ||
Metrics/ModuleLength: | ||
Exclude: | ||
- spec/**/* | ||
Style/RescueModifier: | ||
Style/BlockDelimiters: | ||
Exclude: | ||
- spec/**/* | ||
Metrics/MethodLength: | ||
Exclude: | ||
- spec/interactor/hooks_spec.rb | ||
Style/IndentArray: | ||
Exclude: | ||
- spec/integration_spec.rb | ||
- spec/interactor/hooks_spec.rb | ||
|
||
# Allow nice tree-like comments in specs | ||
Style/AsciiComments: | ||
Exclude: | ||
- spec/integration_spec.rb | ||
|
||
# Here inconsistent indentation helps to understand | ||
# tree nature of callbacks. | ||
# Here, inconsistent indentation helps to understand tree nature of callbacks. | ||
Style/AlignArray: | ||
Exclude: | ||
- spec/integration_spec.rb | ||
|
||
# This could be removed if throws are used instead of | ||
# raising Failure in #fail! | ||
# TODO: Remove when throw is used rather than raise in Interactor::Context.fail! | ||
Lint/HandleExceptions: | ||
Exclude: | ||
- lib/interactor.rb | ||
Style/RescueModifier: | ||
Exclude: | ||
- spec/**/* | ||
|
||
# These style conventions are personal preference. | ||
Style/EmptyMethod: | ||
Enabled: false | ||
|
||
AllCops: | ||
TargetRubyVersion: 2.0 | ||
Style/IndentArray: | ||
EnforcedStyle: consistent | ||
Style/StringLiterals: | ||
EnforcedStyle: double_quotes | ||
Style/SymbolArray: | ||
Enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# encoding: utf-8 | ||
|
||
require "English" | ||
|
||
Gem::Specification.new do |spec| | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters