Relax gemspec to allow Rails 8.0; add Rails main branch to CI #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 8 does not have an alpha or beta rubygems release, but it sounds like a release is imminent (to coincide with Rails World in late September). To prepare for Rails 8, this PR relaxes the Rails requirement in the audited gemspec to allow "< 8.1" instead of "< 8.0". This will allow audited to be used with Rails 8.0 when it is released. To test that audited will work with Rails 8, I added a `rails-main` Gemfile to `Appraisals` that targets the Rails main branch, and included this in the CI matrix.
danielmorrison
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 8 does not have an alpha or beta rubygems release, but it sounds like a release is imminent (to coincide with Rails World in late September).
To prepare for Rails 8, this PR relaxes the Rails requirement in the audited gemspec to allow "< 8.1" instead of "< 8.0". This will allow audited to be used with Rails 8.0 when it is released.
To test that audited will work with Rails 8, I added a
rails_mainGemfile toAppraisalsthat targets the Rails main branch, and included this in the CI matrix.