Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env multiple urls #63

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Env multiple urls #63

merged 6 commits into from
Jun 24, 2024

Conversation

MAX-786
Copy link
Member

@MAX-786 MAX-786 commented Jun 22, 2024

Fixes #62

this includes example .env, you can add multiple urls in that format.

Screenshot from 2024-06-22 09-20-43

@MAX-786 MAX-786 requested a review from djay June 22, 2024 03:54
@djay
Copy link
Member

djay commented Jun 22, 2024

Where does it document the env variable to use and the format?

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 22, 2024

Where does it document the env variable to use and the format?

They are in the env.example in root directory, I'll document it at section - setting up local instance of hydra.

@MAX-786 MAX-786 requested a review from djay June 22, 2024 13:35
@djay
Copy link
Member

djay commented Jun 22, 2024

Include it in the readme I think

@MAX-786
Copy link
Member Author

MAX-786 commented Jun 22, 2024

@@ -60,16 +60,20 @@ To test against a local hydra instance
```bash
make start
```
- You can also set your preset frontend URLs with environment variables, making them available in the admin UI. This allows you to switch between them seamlessly:
```bash
RAZZLE_DEFAULT_IFRAME_URL=http://localhost:3002,https://hydra-blogsite-nextjs.vercel.app pnpm start
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the "pnpm start" for? mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its intended, if we want to pass env vars, it was discussed with Jeff

@MAX-786 MAX-786 merged commit 5a29d4b into main Jun 24, 2024
1 check passed
@MAX-786 MAX-786 deleted the env-multiple-urls branch June 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change the env variable to it allows more than one preset frontend to make it easier to pick
2 participants