Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up the docstring for icalendar.prop.vPeriod #746

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

stevepiercy
Copy link
Member

@stevepiercy stevepiercy commented Nov 21, 2024

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 11972144061

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.075%

Totals Coverage Status
Change from base Build 11971956834: 0.0%
Covered Lines: 4538
Relevant Lines: 4715

💛 - Coveralls

@stevepiercy
Copy link
Member Author

I just reformatted all the docstrings. It was a total mess. Now it is legible as HTML.

However, we should consider adopting a docstring standard, and document that adoption. I recommend Google docstring, as describe in this post:

https://stackoverflow.com/a/24385103/2214933

@niccokunzmann
Copy link
Member

Hi that looks good!

@niccokunzmann niccokunzmann merged commit 590c4b6 into main Nov 22, 2024
19 checks passed
@niccokunzmann niccokunzmann deleted the prop-docstring branch November 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants