Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested with dateutil timezones #732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtrd3v
Copy link
Contributor

@mtrd3v mtrd3v commented Oct 14, 2024

This PR will fix the issue #691.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11329186809

Details

  • 20 of 38 (52.63%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 96.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/timezone/dateutil.py 20 38 52.63%
Totals Coverage Status
Change from base Build 11317448813: -0.5%
Covered Lines: 3520
Relevant Lines: 3630

💛 - Coveralls

@niccokunzmann
Copy link
Member

niccokunzmann commented Oct 14, 2024

Hi, thanks for submitting this. Please add the test fixture param so that all tests also run with this timezone provider. I will hesitate to ship untested code and claim that it would work.

  • parametrize tests
    def pytest_generate_tests(metafunc):
  • add documentation on how to switch to dateutil
  • add tests to make sure edge cases are considered (I do not know which ones these are)

@mtrd3v
Copy link
Contributor Author

mtrd3v commented Oct 14, 2024

We are currently working on it. Will do that!

@niccokunzmann
Copy link
Member

Have fun! I will be back tomorrow possibly :)

@niccokunzmann
Copy link
Member

If you need any help or you would like a review, please do not hesitate to notify us here. Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants