-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor test_create_to_ical from test_encoding to test_examples.py #439
refactor test_create_to_ical from test_encoding to test_examples.py #439
Conversation
@@ -0,0 +1,41 @@ | |||
'''tests ensuring that *the* way of doing things works''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring does not explain anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know what to do with it. I would need to reconnect to the value of refactoring this. It seems to be an ok refactoring. It can be merged as I have nothing against it except from the docstring. I mean in short: it does not hurt and I have nothing against it.
@jacadzaca, could you create an issue for this? I would find it nice if
As a suggestion, one could use doctest What do you think? |
I'm off to bed now, but I'll gladly file it tomorrow :) |
@niccokunzmann is #443 OK? |
I commented. Could I edit it to make it more beginner friendly?
|
So, yes, thanks that is quite a good start. I could not have listed all the issues.
|
Feel free to edit it :) |
Refactor
test_create_to_ical
,test_create_event_simple
andtest_unicode_parameter_name
from test_encoding along the lines of #374, move them totest_examples.py
.