fix the search in folder that is set as default item of the parent folder #66
+151
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder it looks in the folder above because it assumes that the default view is not folderish
Mychae1
changed the title
Mychae1
changed the title
gotcha
force-pushed
the
folder_as_defaultview
branch
from
56916cb
to
860d655
Compare
gotcha
force-pushed
the
folder_as_defaultview
branch
from
860d655
to
ad7556b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page is set as default view in folder "foo", then the search will look in folder foo when searching on the page.
When a folder "bar" is set as default view of the folder foo, the search will search in foo instead of folder bar when doing the search on bar, while it should search on bar instead (in my opinion)