Py3 Update

[1letter]

• remove Python3.7 support
• linting code
• remove Plone 4 Support

[MrTango]

maybe remove the travis config ;)

[MrTango]

I think you need this file too:
https://github.com/collective/plone.app.imagecropping/blob/master/.github/workflows/tests.yml
And there you can also define the versions for Python and Plone.

[1letter]

maybe remove the travis config ;)

Where can i do this? travis.yml is removed in the code base.

[1letter]

I think you need this file too: https://github.com/collective/plone.app.imagecropping/blob/master/.github/workflows/tests.yml And there you can also define the versions for Python and Plone.

No, i use this file https://github.com/plone/meta/blob/8c30aa23ab450d9912c7cc2177c2b88a099c11a2/.github/workflows/test.yml#L19

It's only a variables definition needed

More Info: plone/meta#190

[MrTango]

you are right, forget the travis comment. For the variable, this probably is a permission thing, but i don't know if can really solve this for everyone. I'll have a look into this repo, i should have the rights to change something.

[MrTango]

i added you to the maintainer role, can you please try if that's enough to set the variables?

[1letter]

i added you to the maintainer role, can you please try if that's enough to set the variables?

No, Administrator Access is needed https://docs.github.com/en/actions/learn-github-actions/variables#creating-configuration-variables-for-an-environment

[1letter]

you are right, forget the travis comment. For the variable, this probably is a permission thing, but i don't know if can really solve this for everyone. I'll have a look into this repo, i should have the rights to change something.

Same permission problem for section "integration" under settings
. This is the place where the travis check is configured, perhaps.

[MrTango]

i couldn't find any travis settings in settings, only codcov app.
But maybe it's because in the main branch it is still configured, if everything else is green, merge it and see whats left on issues. Otherwise i agree with @fredvd on setting versions directly in the actions config.

[1letter]

i couldn't find any travis settings in settings, only codcov app. But maybe it's because in the main branch it is still configured, if everything else is green, merge it and see whats left on issues. Otherwise i agree with @fredvd on setting versions directly in the actions config.

I can't merge, because the unwanted and unneeded travis check is configured ;-)

[1letter]

@espenmn can you review polease or should i ask another user?