Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of OCaml and Dune #158

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Formatting of OCaml and Dune #158

merged 4 commits into from
Apr 28, 2023

Conversation

Niols
Copy link
Member

@Niols Niols commented Apr 24, 2023

No description provided.

@yurug
Copy link
Contributor

yurug commented Apr 24, 2023

Instead of using ocp-indent, should we use ocamlformat?

@Niols
Copy link
Member Author

Niols commented Apr 24, 2023

Personally, I have never managed to get used to OCamlFormat. I find its rules way to rigid for a clean formatting. I have been using Topiary with some success but it is still a very young tool that will be subject to frequent changes and it is not available in package managers just yet.

Right now, the goal was just to enforce some consistency in CI, assuming that ocp-indent was pretty much already here considering that we all used Emacs and Tuareg at the time. You can actually see in the files changed that ocp-indent was pretty much respected everywhere. I am also fine enforcing something much stronger and, since I'm not the one touching the OCaml codebase the most, I don't really have a strong opinion on the tool. OCamlFormat is fine.

WDYT?

@Niols
Copy link
Member Author

Niols commented Apr 28, 2023

I moved the discussion on OCamlFormat to #160. This PR is only here to enforce automatically something that was already respected in the past.

@Niols Niols marked this pull request as ready for review April 28, 2023 17:26
@Niols Niols merged commit 650c675 into main Apr 28, 2023
@Niols Niols deleted the code-quality branch April 28, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants