separate typecheck from runtime testing (#3647)

* separate typecheck from runtime testing * Fix tests * Fix typechecking * Remove failures * Test on latest and next TS only --------- Co-authored-by: Misha Kaletsky <[email protected]> Co-authored-by: Colin McDonnell <[email protected]>
colinhacks · Jul 18, 2024 · 957da06 · 957da06
1 parent c6bb75f
commit 957da06
Show file tree

Hide file tree

Showing 9 changed files with 156 additions and 226 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -18,7 +18,7 @@ jobs:
     strategy:
       matrix:
         node: ["latest"]
-        typescript: ["5.0", "next"]
+        typescript: ["latest", "next"]
     name: Test with TypeScript ${{ matrix.typescript }} on Node ${{ matrix.node }}
     steps:
       - uses: actions/checkout@v4

diff --git a/experiments/oops.ts b/experiments/oops.ts
@@ -1,3 +1,5 @@
+// @ts-nocheck
+
 // a less object-oriented approach
 
 interface ZodDef {

diff --git a/experiments/replacer.ts b/experiments/replacer.ts
@@ -1,3 +1,5 @@
+// @ts-nocheck
+
 import type { z } from "../packages/zod/src/index";
 
 type Tagged = z.ZodType & { _tag: string };

diff --git a/package.json b/package.json
@@ -37,7 +37,7 @@
     "tslib": "^2.3.1",
     "tsx": "^4.15.4",
     "typescript": "5.5.3",
-    "vitest": "^1.6.0"
+    "vitest": "2.0.3"
   },
   "lint-staged": {
     "src/*.ts": ["biome format --write", "biome lint --apply"],

diff --git a/packages/zod/tests/types.test-d.ts b/packages/zod/tests/types.test-d.ts
@@ -0,0 +1,3 @@
+import { z } from "../src/index";
+
+z;
diff --git a/packages/zod/vitest.config.ts b/packages/zod/vitest.config.ts
@@ -1,4 +1,4 @@
-import { defineConfig, mergeConfig } from "vitest/config";
+import { defineProject, mergeConfig } from "vitest/config";
 import rootConfig from "../../vitest.root";
 
-export default mergeConfig(rootConfig, defineConfig({})) as object;
+export default mergeConfig(rootConfig, defineProject({})) as object;
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/vitest.root.ts b/vitest.root.ts
@@ -2,13 +2,11 @@ import { type UserConfig, defineConfig } from "vitest/config";
 
 export default defineConfig({
   test: {
-    include: ["**/*.test.ts"],
-    isolate: false,
     watch: false,
+    isolate: false,
     typecheck: {
       enabled: true,
-      ignoreSourceErrors: true,
-      include: ["**/*.test.ts"],
+      ignoreSourceErrors: false,
     },
   },
 }) as UserConfig;
diff --git a/vitest.workspace.ts b/vitest.workspace.ts
@@ -1 +1 @@
-export default ["packages/*"] as [string];
+export default ["packages/*"] as string[];
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export default ["packages/*"] as [string];
		export default ["packages/*"] as string[];