Alternative implementation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --log-base argument is handled differently than other base-folder arguments. Its default value is None, meaning that the environment variable COLCON_LOG_PATH or the default path is used if the command-line argument is missing. As we cannot easily change the default path (which is hardcoded in colcon-core), we override the environment variable instead.
2 tasks
When running from a symlinked subfolder, os.getcwd() and Path.cwd() return the real path with all all symlinks resolved. This resulted in the workspace root to be found w.r.t. the real path instead the actual logical one.
|
Awesome, thank you for implementing symlink resolving. We use those as well 🙂 |
|
Ping @cottsay for a review of this. |
|
How exactly could I use this? I glanced at Colcon docs. However, I did find out how I could install the extension manually. |
|
This looks to be pretty useful. Is there any movement on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the desired behavior by intercepting
add_argument()and installing additional type resolvers for folder arguments to be resolved w.r.t. the workspace root.Realizes colcon/colcon-core#595 (comment)
Fixes #1 (comment)