-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for just configuring cmake projects #119
Conversation
@dirk-thomas PTAL Can we run the CI at least in the meantime? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
Oh yeah, completely forgot I made this PR 😆 and felt the need again. Would there be any progress on this? 😅 |
@kunaltyagi Sorry, I am not a maintainer of this repository anymore. |
You've been pivotal in a ton of projects and it's been a privilege using them. Paging @cottsay (hope this time I get it correct 😂) instead |
@kunaltyagi @cottsay Any news about this? This feature would be a great addition! |
Seems like Scott is quite busy (elsewhere). Lack of activity in a while makes me think this PR wouldn't get merged in a hurry. That's a bit sad since CMake is a key builder for ROS2. |
Please take a look at #124. I'm trying to avoid adding new arguments for such a narrow use case, so I'm proposing we expand the capability of an existing one to support this scenario. |
That PR seems to be orthogonal. If there are no cmake-targets, it performs install, and if there are cmake-targets, it builds them. This PR is to stop cmake right after configuration completes, before building anything. |
This is not true in #124, and was not true with the previous behavior either. Manually specifying targets (including no targets) suppresses the default additional install invocation. |
So, in order to just configure, not build, the invocation would be:
? |
That's correct. Normal arguments could appear after
As stated in the PR, the goal is to allow more than one custom target to be invoked, but it was trivial to support this scenario under that feature as well, without adding an additional command line argument to the already overwhelming list of possible arguments to If you're looking for something that explicitly references only configuring, we could create a mixin that specifies the empty target list so that you could invoke the build with |
Perfect :) |
Thanks for your consideration, @kunaltyagi, and for pushing this issue forward. It would be helpful if you could provide feedback on #124, especially if you'd like to see it merged swiftly. |
|
I have this feature implemented in my own copy of IMO the proposed reuse of |
@okvik How does this work? Without a build, cmake would not generate xxxConfig.cmake for a package, and those packages who depend on it would fail to find dependencies when configuring. |
Fixes #116
rc