Skip to content

Commit

Permalink
Merge pull request #11 from coinbase/patrick/add-versioning-info
Browse files Browse the repository at this point in the history
[Services] Add versioning info
  • Loading branch information
patrick-ogrady authored Sep 21, 2020
2 parents 4f87ff7 + fd4b355 commit ba9d9ce
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
name: default
steps:
- *fast-checkout
- run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.27.0
- run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.30.0
- run: make lint
check-license:
executor:
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ check-comments:
${GOLINT_CMD} -set_exit_status ${GO_FOLDERS} .

lint: | check-comments
golangci-lint run -v -E ${LINT_SETTINGS},gomnd
golangci-lint run --timeout 2m0s -v -E ${LINT_SETTINGS},gomnd

add-license:
${ADDLICENCE_SCRIPT} .
Expand Down
5 changes: 3 additions & 2 deletions services/network_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ func (s *NetworkAPIService) NetworkOptions(
) (*types.NetworkOptionsResponse, *types.Error) {
return &types.NetworkOptionsResponse{
Version: &types.Version{
RosettaVersion: "1.4.2",
NodeVersion: "0.0.1",
RosettaVersion: RosettaVersion,
NodeVersion: NodeVersion,
MiddlewareVersion: &MiddlewareVersion,
},
Allow: &types.Allow{
OperationStatuses: bitcoin.OperationStatuses,
Expand Down
6 changes: 4 additions & 2 deletions services/network_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,12 @@ import (
)

var (
middlewareVersion = "0.0.2"
defaultNetworkOptions = &types.NetworkOptionsResponse{
Version: &types.Version{
RosettaVersion: "1.4.2",
NodeVersion: "0.0.1",
RosettaVersion: "1.4.4",
NodeVersion: "0.20.1",
MiddlewareVersion: &middlewareVersion,
},
Allow: &types.Allow{
OperationStatuses: bitcoin.OperationStatuses,
Expand Down
19 changes: 19 additions & 0 deletions services/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,25 @@ import (
"github.com/coinbase/rosetta-sdk-go/types"
)

const (
// RosettaVersion is the version of the
// Rosetta Specification we are using.
RosettaVersion = "1.4.4"

// NodeVersion is the version of
// bitcoin core we are using.
NodeVersion = "0.20.1"
)

var (
// MiddlewareVersion is the version
// of rosetta-bitcoin. We set this as a
// variable instead of a constant because
// we typically need the pointer of this
// value.
MiddlewareVersion = "0.0.2"
)

// Client is used by the servicers to get Peer information
// and to submit transactions.
type Client interface {
Expand Down

0 comments on commit ba9d9ce

Please sign in to comment.