-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-2412 fix aggregate property casing + add files tests cleanup #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haakonvt
force-pushed
the
fix-aggregate-property-casing
branch
from
December 5, 2024 12:33
ff30db6
to
8527a92
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
- Coverage 90.49% 90.49% -0.01%
==========================================
Files 141 141
Lines 22483 22483
==========================================
- Hits 20346 20345 -1
- Misses 2137 2138 +1
|
haakonvt
changed the title
fix aggregate property casing + add files tests cleanup
DM-2412 fix aggregate property casing + add files tests cleanup
Dec 5, 2024
vvb16
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
haakonvt
force-pushed
the
fix-aggregate-property-casing
branch
from
December 10, 2024 23:17
8527a92
to
e89207d
Compare
haakonvt
commented
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised on slack: https://cognitedata.slack.com/archives/CG10VQPFX/p1733302661860609
aggregate_cardinality_properties