Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-2412 fix aggregate property casing + add files tests cleanup #2059

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Dec 5, 2024

Raised on slack: https://cognitedata.slack.com/archives/CG10VQPFX/p1733302661860609

  1. fix aggregate property casing
  2. add files tests cleanup
  3. fix wrong type annotations for aggregate_cardinality_properties

@haakonvt haakonvt requested review from a team as code owners December 5, 2024 12:03
@haakonvt haakonvt force-pushed the fix-aggregate-property-casing branch from ff30db6 to 8527a92 Compare December 5, 2024 12:33
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (279cda9) to head (106ce42).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cognite/client/_api_client.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2059      +/-   ##
==========================================
- Coverage   90.49%   90.49%   -0.01%     
==========================================
  Files         141      141              
  Lines       22483    22483              
==========================================
- Hits        20346    20345       -1     
- Misses       2137     2138       +1     
Files with missing lines Coverage Δ
cognite/client/_api/documents.py 77.11% <ø> (ø)
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/_api_client.py 90.34% <75.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

@haakonvt haakonvt changed the title fix aggregate property casing + add files tests cleanup DM-2412 fix aggregate property casing + add files tests cleanup Dec 5, 2024
Copy link

@vvb16 vvb16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haakonvt haakonvt force-pushed the fix-aggregate-property-casing branch from 8527a92 to e89207d Compare December 10, 2024 23:17
@haakonvt haakonvt enabled auto-merge (squash) December 10, 2024 23:17
CHANGELOG.md Outdated Show resolved Hide resolved
@haakonvt haakonvt merged commit 8ed1407 into master Dec 10, 2024
15 checks passed
@haakonvt haakonvt deleted the fix-aggregate-property-casing branch December 10, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants