Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError on retrieving an ExtractionPipeline with partial contact information #2056

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Dec 4, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino requested review from a team as code owners December 4, 2024 11:54
Comment on lines +41 to +44
name: str | None = None,
email: str | None = None,
role: str | None = None,
send_notification: bool | None = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class used as both a read and write class? If only read, we don't really want the defaults.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used for both.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (688b956) to head (215890d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2056      +/-   ##
==========================================
- Coverage   90.53%   90.50%   -0.04%     
==========================================
  Files         141      141              
  Lines       22491    22488       -3     
==========================================
- Hits        20363    20353      -10     
- Misses       2128     2135       +7     
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/extractionpipelines.py 90.66% <100.00%> (-0.13%) ⬇️

... and 4 files with indirect coverage changes

@doctrino doctrino force-pushed the extraction-pipeline-list branch from ae8322b to 215890d Compare December 4, 2024 12:00
@doctrino doctrino enabled auto-merge (squash) December 4, 2024 12:07
@doctrino doctrino merged commit fa7f991 into master Dec 4, 2024
16 checks passed
@doctrino doctrino deleted the extraction-pipeline-list branch December 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants