Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: isnull filter #2052

Merged
merged 5 commits into from
Dec 2, 2024
Merged

add: isnull filter #2052

merged 5 commits into from
Dec 2, 2024

Conversation

haakonvt
Copy link
Contributor

@haakonvt haakonvt commented Dec 1, 2024

@haakonvt haakonvt requested review from a team as code owners December 1, 2024 22:38
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (b1e6448) to head (4c9703b).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2052      +/-   ##
==========================================
+ Coverage   90.51%   90.53%   +0.01%     
==========================================
  Files         139      139              
  Lines       22405    22418      +13     
==========================================
+ Hits        20280    20296      +16     
+ Misses       2125     2122       -3
Files with missing lines Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/filters.py 95.82% <100.00%> (+0.14%) ⬆️
cognite/client/utils/useful_types.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

doctrino
doctrino approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@doctrino doctrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, suggest to just merge it.

cognite/client/utils/useful_types.py
@@ -29,5 +29,9 @@ def count(self, value: Any, /) -> int: ...
def __reversed__(self) -> Iterator[_T_co]: ...


def is_sequence_not_str(obj: Any) -> TypeGuard[SequenceNotStr]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@haakonvt haakonvt enabled auto-merge (squash) December 2, 2024 10:57
@haakonvt haakonvt merged commit 1ccd6b1 into master Dec 2, 2024
16 checks passed
@haakonvt haakonvt deleted the add-is-null-filter branch December 2, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctrino doctrino doctrino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonvt @doctrino