Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDF-22413] Simulators Part 1 #1957

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[CDF-22413] Simulators Part 1 #1957

wants to merge 5 commits into from

Conversation

doctrino
Copy link
Contributor

@doctrino doctrino commented Oct 6, 2024

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (8b2b99c) to head (f42cc6c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
+ Coverage   90.21%   90.22%   +0.01%     
==========================================
  Files         135      135              
  Lines       21577    21577              
==========================================
+ Hits        19465    19468       +3     
+ Misses       2112     2109       -3     
Files with missing lines Coverage Δ
cognite/client/data_classes/assets.py 94.26% <100.00%> (ø)
cognite/client/utils/_concurrency.py 89.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@lpereiracgn
Copy link
Contributor

We could close this PR in favor of #2006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants