Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raw rows to pandas (keep all rows) #1806

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Fix raw rows to pandas (keep all rows) #1806

merged 5 commits into from
Jun 13, 2024

Conversation

haakonvt
Copy link
Contributor

[7.49.2] - 2024-06-12

Fixed

  • Converting rows (RowList and RowListWrite) to a pandas DataFrame no longer silently drops rows that do not have
    any columnar data.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@haakonvt haakonvt requested review from a team as code owners June 12, 2024 11:32
@haakonvt haakonvt requested review from mattmurph9 and removed request for a team June 12, 2024 11:32
cognite/client/data_classes/raw.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (c4cf969) to head (2ff8569).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1806      +/-   ##
==========================================
- Coverage   92.93%   92.91%   -0.03%     
==========================================
  Files         121      121              
  Lines       17700    17703       +3     
==========================================
- Hits        16450    16449       -1     
- Misses       1250     1254       +4     
Files Coverage Δ
cognite/client/_version.py 100.00% <100.00%> (ø)
cognite/client/data_classes/raw.py 92.42% <100.00%> (+0.17%) ⬆️

... and 3 files with indirect coverage changes

@haakonvt haakonvt enabled auto-merge (squash) June 13, 2024 08:34
@haakonvt haakonvt merged commit e675cee into master Jun 13, 2024
13 checks passed
@haakonvt haakonvt deleted the fix-rows-to-pandas branch June 13, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants