-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Added CI for pyodide #1801
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1801 +/- ##
==========================================
+ Coverage 92.90% 92.91% +0.01%
==========================================
Files 121 121
Lines 17700 17700
==========================================
+ Hits 16444 16446 +2
+ Misses 1256 1254 -2 |
What are the differences now between test jupyter and test streamlit? |
Now it's only a minor version difference on Pyodide. But we will add the different set of packages they use in addition. |
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: ./.github/actions/setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed? It just sets up python and poetry (+ deps) (with some additional caching)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need that for building the SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also see that I don't run poetry install
, not sure why this works :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need that for building the SDK?
Oh, right, yeah for sure needed with poetry at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
3c1e92d
to
51cd268
Compare
Description
Closes https://github.com/cognitedata/cog-ai/issues/2336
The Python SDK is heavily used in our Jupyter notebook and Streamlit environment which is Pyodide based. To ensure compatibility, I have added a CI step that verifies that the SDK can be installed and imported in Pyodide.
The test is implemented as a nodejs script triggered by GitHub workflows, one for Jupyter and one for Streamlit.
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.