[Not ready] add warning when mixing nodata/mask/alpha #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to morecantile3 * remove python 3.6 * make sure to use rio-cogeo2.3.1 in tests * 🤦 * use rio-cogeo from github * update fixtures and tests * update changelog
* remove default max_size for part and feature * ignore type, failing in python 3.9
* MAX_THREADS to RIO_TILER_MAX_THREADS * Update env variable in docs * Add to changelog * Update CHANGES.md Co-authored-by: Vincent Sarago <[email protected]>
* allow non-earth dataset * fix stac * metadata/info returns `geographic_bounds` * add test for non earth object tile reading * add notebook * update changelog * update docs * update * revert and remove min/max zoom in __init__ * edit changes
* Replace requests with httpx * Use httpx instead of requests * Use httpx in notebooks * Add tox to dev requirements * Revert change and remove unused import * update changelog Co-authored-by: Vincent Sarago <[email protected]>
* add new statistics methods and band names in ImageData object * update base classes and tests * MultiBandReader.statistics should use self.preview as COGReader * update tests
* change asset_expression type and add asset_indexes * update changelog * moar docs
|
The rasterio issue was marked as Non-Fix so we'll raise a warning here |
|
I'm seeing a 10ms time increase using this branch (~40ms instead of 30ms). Locally using gdal 3.3.2 and rasterio sources I don't see any difference 🤷♂️ Because this PR just adds a warning I will not merge it for now. |
vincentsarago
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #401
let first see how rasterio/rasterio#2233 goes