Code quality maintenance, fixes and general improvements #153

coenjacobs · 2024-09-12T13:47:49Z

Removed PhpStan baseline file (phpstan-baseline.neon) and fixed previously unflagged errors
Added phpmd to reduce complexity and code smells (Adding phpmd as code quality ensurance #154)
Enforce docblocks complexity via code checks (Enforce docblocks complexity via code checks #155)
Changed coding standards to follow PSR-12 (which it already kind of sort of was)

Adding phpmd as code quality ensurance

Enforce docblocks complexity via code checks

coenjacobs added 26 commits September 12, 2024 15:45

Remove phpstan baseline as it is old and obsolete

eebcee9

Fixes resulting from no phpstan baseline being used anymore

ef3b2dc

Bump PHP and Composer versions to latest stables

eac01ed

Installed phpmd and basic configuration file

7bc393e

Fixed all code smells in main replacer class

45f76f5

Change boolean load dependencies flag to separate method

707f808

CamelCasing all the things

716cb13

Dumbed down if else constructions in autoloader classes

f40546a

Reduce Mover complexity by abstracting file handling to FileHandler

b8ebe68

Remove else case from moveFile method to reduce complexity

8974877

Setters for underscore case properties translated to snakeCase

7f1a140

Removed all static calls that shouldn't be static in the first place

26cc7d6

Reduce complexity of moveFile method on Mover class

10e709b

Reduce complexity of movePackage method

00470e7

Reduce complexity of deleteDepTargetDirs methods

defd190

Reduce Mover complexity by defering file path handling to autoloaders

be0ba40

Suppress parameter not being used as it extends Symfony command class

3f8e10c

Add phpmd to test script and GitHub Actions

b1a58c5

Merge pull request #154 from coenjacobs/phpmd-experiment

952d847

Adding phpmd as code quality ensurance

Cleanup, documentation fixes and formatting

36a61f7

Enforce docblocks for complex methods by set thresholds

4a5a07d

Added enforced docblocks for complex methods

58e0644

Add doc check to GitHub Actions steps

e755e61

Merge pull request #155 from coenjacobs/enforce-docblocks-complexity

b7f2029

Enforce docblocks complexity via code checks

Change coding standard to PSR-12

f054665

Minor changes to pass PSR-12 coding standards

0d7ae1a

Provide feedback