Pass unit as part of promethious metadata.

Signed-off-by: Cody Littley <[email protected]>
cody-littley · Nov 21, 2024 · 2d6c116 · 2d6c116
1 parent 49b11e1
commit 2d6c116
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/common/metrics/count_metric.go b/common/metrics/count_metric.go
@@ -27,7 +27,7 @@ type countMetric struct {
 func newCountMetric(name string, label string, description string, vec *prometheus.CounterVec) CountMetric {
 	var counter prometheus.Counter
 	if vec != nil {
-		counter = vec.WithLabelValues(label)
+		counter = vec.WithLabelValues(label, "count")
 	}
 
 	return &countMetric{

diff --git a/common/metrics/gauge_metric.go b/common/metrics/gauge_metric.go
@@ -36,7 +36,7 @@ func newGaugeMetric(
 
 	var gauge prometheus.Gauge
 	if vec != nil {
-		gauge = vec.WithLabelValues(label)
+		gauge = vec.WithLabelValues(label, unit)
 	}
 
 	return &gaugeMetric{

diff --git a/common/metrics/latency_metric.go b/common/metrics/latency_metric.go
@@ -28,7 +28,7 @@ type latencyMetric struct {
 func newLatencyMetric(name string, label string, description string, vec *prometheus.SummaryVec) LatencyMetric {
 	var observer prometheus.Observer
 	if vec != nil {
-		observer = vec.WithLabelValues(label)
+		observer = vec.WithLabelValues(label, "seconds")
 	}
 
 	return &latencyMetric{

diff --git a/common/metrics/metrics_server.go b/common/metrics/metrics_server.go
@@ -211,7 +211,7 @@ func (m *metrics) NewLatencyMetric(
 				Name:       name,
 				Objectives: objectives,
 			},
-			[]string{"label"},
+			[]string{"label", "unit"},
 		)
 		m.summaryVecMap[name] = vec
 	}
@@ -256,7 +256,7 @@ func (m *metrics) NewCountMetric(
 				Namespace: m.config.Namespace,
 				Name:      name,
 			},
-			[]string{"label"},
+			[]string{"label", "unit"},
 		)
 		m.counterVecMap[name] = vec
 	}
@@ -312,7 +312,7 @@ func (m *metrics) newGaugeMetricUnsafe(
 				Namespace: m.config.Namespace,
 				Name:      name,
 			},
-			[]string{"label"},
+			[]string{"label", "unit"},
 		)
 		m.gaugeVecMap[name] = vec
 	}

diff --git a/common/metrics/test/main.go b/common/metrics/test/main.go
@@ -1,4 +1,4 @@
-package test
+package main
 
 import (
 	"fmt"