bug: laminas#135 Add numeric state test to check if string is a real …

…number Signed-off-by: codisart <[email protected]>
codisart · Jan 12, 2023 · 6be9176 · 6be9176
1 parent aba4be7
commit 6be9176
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/GpsPoint.php b/src/GpsPoint.php
@@ -53,7 +53,7 @@ private function isValidCoordinate(string $value, float $maxBoundary): bool
             $value = $this->removeDegreeSign($value);
         }
 
-        if ($value === false || $value === null) {
+        if ($value === false || $value === null || !is_numeric($value)) {
             $this->error(self::CONVERT_ERROR);
             return false;
         }

diff --git a/test/GPSPointTest.php b/test/GPSPointTest.php
@@ -86,10 +86,11 @@ public function basicDataProvider(): array
     public function errorMessageTestValues(): array
     {
         return [
-            ['63 47 24.691 N, 18 2 54.363 W', GpsPoint::OUT_OF_BOUNDS, '63 47 24.691 N'],
+            ['63 47 24.691 N, 18 2 54.363 W', GpsPoint::CONVERT_ERROR, '63 47 24.691 N'],
+            ['65° 4\' N,-22.728867530822754', GpsPoint::CONVERT_ERROR, '65° 4\' N'],
             ['° \' " N,° \' " E', GpsPoint::CONVERT_ERROR, '° \' " N'],
             ['° \' " N', GpsPoint::INCOMPLETE_COORDINATE, '° \' " N'],
-            ['foo,bar', GpsPoint::CONVERT_ERROR, '° \' " N'],
+            ['foo,bar', GpsPoint::CONVERT_ERROR, 'foo'],
         ];
     }
 }