Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrib workflow/correct #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Contrib workflow/correct #153

wants to merge 3 commits into from

Conversation

g-sam
Copy link
Contributor

@g-sam g-sam commented Apr 14, 2016

  • corrected some typos
  • added instruction to ensure branches are from master
  • corrected detail about deletion (the command given is for deleting from the local repo)

@g-sam g-sam assigned ozym11 and unassigned cshg May 20, 2016
@g-sam
Copy link
Contributor Author

g-sam commented May 20, 2016

@Ozymandias1 So here are my proposed fixes to the git instructions. If you think they should be merged, please make sure you've tested them and they are definitely correct. Thanks!

@ozym11
Copy link
Contributor

ozym11 commented May 20, 2016

@g-sam I'm cool with these changes, I would only suggest one minor edit because of clarity:

"To delete the branch from your local repository as well, execute the following terminal command:"

"To delete the branch from both the Git repository AND your local repository, execute the following terminal command:"

let me know what oyu think.

@g-sam
Copy link
Contributor Author

g-sam commented May 20, 2016

As far as I'm aware git branch -D <name of the branch> wont delete the branch in the GitHub repository -- that has to be done on the website. Is that correct?

@ozym11
Copy link
Contributor

ozym11 commented May 24, 2016

As far as I'm aware git branch -D wont delete the branch in the GitHub repository -- that has to be done on the website. Is that correct?

I have not tested it, but I have checked over at stack-overflow and here. Both sources corroborate what you said - $git branch -D deletes local branch only.

My initial suggestion was because of language clarity, so I would still recommend a commit changing:

"To delete the branch from your local repository as well, execute the following terminal command:"

to

"Additionally, to delete the branch from your local repository, execute the following terminal command:"

@g-sam
Copy link
Contributor Author

g-sam commented May 28, 2016

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants