Skip to content

Commit

Permalink
Fix two column motif area content measuring
Browse files Browse the repository at this point in the history
Ensure content probe element has correct width. Caused two column
layout to move content down even if motif fits nexts to cotnent.

This went unnoticed since storybook used v2 frontend. Switch storybook
back to v1 frontend since this what is still used in production.

REDMINE-20384
  • Loading branch information
tf committed Aug 30, 2023
1 parent 1ea1edd commit 71385d6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ namespace :pageflow_scrolled do

account = seeds.account(name: 'storybook-seed') do |account_in_progress|
account_in_progress.features_configuration =
account_in_progress.features_configuration.merge('scrolled_entry_type' => true,
'frontend_v2' => true)
account_in_progress.features_configuration.merge('scrolled_entry_type' => true)
end

seeds.sample_scrolled_entry(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function TwoColumn(props) {
<div className={classNames(styles.root, styles[props.align],
narrow ? styles.narrowViewport : styles.wideViewport)}>
<div className={classNames(styles.group)} key={props.align}>
<div className={styles.inline} ref={props.contentAreaRef} />
<div className={classNames(styles.box, styles.inline)} ref={props.contentAreaRef} />
</div>
{renderItems(props, narrow)}
{renderPlaceholder(props.placeholder)}
Expand Down

0 comments on commit 71385d6

Please sign in to comment.