increase responseTimoeut to 5 seconds #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm ... the default timeout seems to work just fine for most cases .. so I would more think it could be an idea to allow override by constructor option or - if it is "command specific" - then also an override for the "send" method ... More then doubling it for all cases where "some commands" are affected feels a bit overkill. WDYT? |
|
@jonnytest1 do you want to provide an update to our pr or should I do when back from vacation in a week? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thats literally it in the title
i had some commands failing but overwrtiing the repsonse timeout to a bit longer helped