-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[team-12] Eamon & Autumn 3주차 PR #47
Open
deprecated-hongbiii
wants to merge
42
commits into
codesquad-members-2021:team-12
Choose a base branch
from
kyupid:dev/FE
base: team-12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[team-12] Eamon & Autumn 3주차 PR #47
deprecated-hongbiii
wants to merge
42
commits into
codesquad-members-2021:team-12
from
kyupid:dev/FE
Commits on Jun 15, 2021
-
[#37] Feat: 서버에서 filter list 받아서 화면에 표시 (#38)
- recoil의 selector를 사용해서 하는 중 - 담당자, 작성자 조회 쪽 API에 문제가 있어 주석처리 해둠 - 로딩 처리 및 데이터 업데이트에 관해서 고민 더 필요
Configuration menu - View commit details
-
Copy full SHA for 0d99911 - Browse repository at this point
Copy the full SHA 0d99911View commit details
Commits on Jun 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 479a782 - Browse repository at this point
Copy the full SHA 479a782View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96043c2 - Browse repository at this point
Copy the full SHA 96043c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e66fbd - Browse repository at this point
Copy the full SHA 8e66fbdView commit details -
[#40] Style: 0번째 comment margin값 수정, 새 코멘트 ui 추가 (#45)
- 사이드바 컴포넌트(현재 이름 NewIssueRight)는 재사용을 위해 수정이 필요해서 일단 비워놨음
Configuration menu - View commit details
-
Copy full SHA for 8ab9696 - Browse repository at this point
Copy the full SHA 8ab9696View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b4a67 - Browse repository at this point
Copy the full SHA 56b4a67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2899b06 - Browse repository at this point
Copy the full SHA 2899b06View commit details -
[#50] 라벨 목록 페이지 - 서버로부터 받은 데이터를 상태에 저장하여 렌더링하도록 수정 (#53)
* [#50] Chore: store.ts에 주석 처리해뒀던 get요청 부활 - 배열로 응답하도록 API가 수정됐기 때문에 비로소 부활시킬 수 있었다.. - text_color 속성이 추가됐고 label title과 description을 구분하여 저장 * [#50] Chore: 사용하지 않는 import 제거 * [#50] Refactor: LabelPage recoil value 사용해서 화면 렌더링 - 수정 과정에서 LabelItemType 정의가 필요해서 store.ts에 타입 정의함 - 추후 타입들만 따로 모아놓도록 리팩토링 해야할 듯... * [#50] Style: 라벨 목록 페이지 css 살짝 손봄
Configuration menu - View commit details
-
Copy full SHA for f3c86ce - Browse repository at this point
Copy the full SHA f3c86ceView commit details
Commits on Jun 18, 2021
-
[#52] Refactor: 코드리뷰 일부 반영, 타입선언 파일 분리, 자잘한 오타 수정 (#55)
- 코드 리뷰 중 mock 데이터 부분과 useAxios는 제외 - recoil selector에서 선언해둔 타입과 mock 배열로 렌더링하느라 선언한 타입의 속성 이름이 서로 달라서 고치다보니 답이 없어서 일단 이슈 목록 페이지 부분의 배열데이터를 주석처리함
Configuration menu - View commit details
-
Copy full SHA for 4ba6c56 - Browse repository at this point
Copy the full SHA 4ba6c56View commit details
Commits on Jun 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1187874 - Browse repository at this point
Copy the full SHA 1187874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7a9e8 - Browse repository at this point
Copy the full SHA 4c7a9e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81b42f8 - Browse repository at this point
Copy the full SHA 81b42f8View commit details -
[#50] 마일스톤 페이지 API 이용하여 렌더링 (#80)
* [#50] Add: 마일스톤 페이지 서버로부터 받은 데이터로 렌더링하기 위한 상태 생성 - 코드가 너무 중복이지만 일단 closed 여부에 따른 요청 나눠서 마일스톤 selector 만듦 - 마일스톤 관련 selector를 stores/milestoneStore.ts 로 분리 * [#50] Feat: 열린 마일스톤, 닫힌 마일스톤 버튼 클릭에 따라 렌더링 - 중복 코드 매우 많음 - 어떤 탭이 클릭됐는지 상태 관리하기 위해 Milestones.tsx 에 isOpenedMilestoneTab라는 상태를 만들어서 해결 - 하지만 atom을 사용하여 selector가 해당 atom을 구독하게 하면 더 깔끔해질 듯 (리팩토링 예정)
Configuration menu - View commit details
-
Copy full SHA for 7a18dbc - Browse repository at this point
Copy the full SHA 7a18dbcView commit details
Commits on Jun 22, 2021
-
[#82] Feat: 이슈 목록에서 이슈 클릭 시 상세 페이지로 라우팅 (#90)
- Route의 순서를 약간 바꿨음 - API에 수정할 사항이 있어서 아직 서버에서 받은 데이터로 렌더링은 못 한 상태
Configuration menu - View commit details
-
Copy full SHA for 4b43911 - Browse repository at this point
Copy the full SHA 4b43911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e286d3 - Browse repository at this point
Copy the full SHA 8e286d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddbc978 - Browse repository at this point
Copy the full SHA ddbc978View commit details
Commits on Jun 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 03dc60f - Browse repository at this point
Copy the full SHA 03dc60fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 700d4a7 - Browse repository at this point
Copy the full SHA 700d4a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d65ff3 - Browse repository at this point
Copy the full SHA 5d65ff3View commit details
Commits on Jun 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ffe871e - Browse repository at this point
Copy the full SHA ffe871eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 230bdae - Browse repository at this point
Copy the full SHA 230bdaeView commit details -
* [#82] Feat: 이슈 상세 페이지 헤더 부분 서버 데이터로 렌더링 - IssueDetailHeader에서 디스트럭쳐링 하고 싶었는데 타입 에러 때문에 못 함 * [#82] Feat: 이슈 상세페이지 본문, 코멘트 서버에서 받은 데이터로 렌더링 * [#82] Feat: 이슈 작성자 === 댓글 작성자 일 때 '작성자' 라벨 붙여주는 로직 추가 * [#82] Feat: 이슈 작성자 === 댓글 작성자 일 때 '작성자' 라벨 붙여주는 로직 추가 - Comment 컴포넌트에서 바로 issue author id를 알 수 없어서 atom을 새로 만듦 - issueDetailQuery 요청에서 /api/issues/null 로 요청하게 되는 에러가 있음 * [#82] Fix: clickedIssueId의 초기값 null이 요청 url에 들어가서 생기는 에러 해결 - null일 경우 early return하게 해서 해결했다. * [#82] Feat: 이슈 상세 페이지 로그인 유저 === 코멘트 작성자 이면 편집 버튼 노출 * [#82] Feat: 코멘트 작성 부분에 loginUser 정보를 바탕으로 아바타 렌더링 - Avatar에 더이상 name 속성이 필요 없어서 삭제
Configuration menu - View commit details
-
Copy full SHA for cd5ea6e - Browse repository at this point
Copy the full SHA cd5ea6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 790e95e - Browse repository at this point
Copy the full SHA 790e95eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 416e7e0 - Browse repository at this point
Copy the full SHA 416e7e0View commit details -
* [#111] Feat: 코멘트 작성란에 파일첨부 ui 추가 * [#111] 코멘트 작성 버튼 ui 생성 * [#52][#82] Refactor: 이슈 상세 페이지 관련 store 파일 분리 * [#111] Chore: CommentTextarea를 공통 컴포넌트로 사용하기 위한 작업 - 이슈 생성, 코멘트 생성, 코멘트 편집에서 공통으로 사용되기 때문에 각각의 atom을 만들어서 각각의 CommentTextarea의 부모 컴포넌트에서 setAtom을 props로 내려줌 * [#82] Feat: 코멘트 작성 기능 - post 요청에서 다양한 에러 나는 중... 404, 415, 500
Configuration menu - View commit details
-
Copy full SHA for 7cf1efc - Browse repository at this point
Copy the full SHA 7cf1efcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 521af31 - Browse repository at this point
Copy the full SHA 521af31View commit details -
Configuration menu - View commit details
-
Copy full SHA for b40b74a - Browse repository at this point
Copy the full SHA b40b74aView commit details
Commits on Jun 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8546a31 - Browse repository at this point
Copy the full SHA 8546a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2ca06c - Browse repository at this point
Copy the full SHA e2ca06cView commit details
Commits on Jun 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1c20976 - Browse repository at this point
Copy the full SHA 1c20976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0be6c0d - Browse repository at this point
Copy the full SHA 0be6c0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 906efcb - Browse repository at this point
Copy the full SHA 906efcbView commit details
Commits on Jun 30, 2021
-
* Refactor: 리다이렉트 url env 로 변경 * Feat:logOut 기능 구현
Configuration menu - View commit details
-
Copy full SHA for a02d5f1 - Browse repository at this point
Copy the full SHA a02d5f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e9cd41 - Browse repository at this point
Copy the full SHA 3e9cd41View commit details
Commits on Jul 1, 2021
-
* [#131]Feat: headerParser&emphasisParser * chore: markdown preview 제거
Configuration menu - View commit details
-
Copy full SHA for 0445995 - Browse repository at this point
Copy the full SHA 0445995View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6072f2d - Browse repository at this point
Copy the full SHA 6072f2dView commit details -
[#82] Feat & Fix: 이슈 상세 페이지에 사이드바 렌더링 (#135)
- 사이드바 컴포넌트를 재사용하기 위해 이슈 생성 페이지에서 상태를 reset 하는 로직을 만듦
Configuration menu - View commit details
-
Copy full SHA for d79c083 - Browse repository at this point
Copy the full SHA d79c083View commit details
Commits on Jul 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a722aeb - Browse repository at this point
Copy the full SHA a722aebView commit details -
[#82] Feat: 이슈 삭제 기능 추가 (#139)
- 삭제는 잘 되지만 열린이슈/닫힌이슈 카운트가 업데이트 안 됨
Configuration menu - View commit details
-
Copy full SHA for ea65d42 - Browse repository at this point
Copy the full SHA ea65d42View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8abb4a - Browse repository at this point
Copy the full SHA d8abb4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0214e71 - Browse repository at this point
Copy the full SHA 0214e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 553b974 - Browse repository at this point
Copy the full SHA 553b974View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.