Chat server #39
Chat server #39
Conversation
Create initial CMakeList Implement basic version of chat server
| qInfo() << "Server listening on port " << port; | ||
| connect(m_webSocketServer, &QWebSocketServer::newConnection, this, &ChatServer::onNewConnection); | ||
| connect(&*m_webSocketServer, &QWebSocketServer::newConnection, this, &ChatServer::onNewConnection); |
There was a problem hiding this comment.
please use m_webSocketServer.get()
| } | ||
|
|
||
| ChatServer::ChatServer(quint16 port, QObject *parent) | ||
| ChatServer::ChatServer(quint16 port, QObject* parent) |
| QWebSocketServer* m_webSocketServer; | ||
| QList<QWebSocket*> m_clients; | ||
| std::unique_ptr<QWebSocketServer> m_webSocketServer; | ||
| std::vector<std::unique_ptr<QWebSocket*>> m_clients; |
There was a problem hiding this comment.
I think we shouldn't use std::vector<std::unique_ptr to raw pointers, this may cause memory problems
There was a problem hiding this comment.
Do you have other idea? We have to store QWebSocket*, there is no option to store as a normal type
|
@Vicx95 Your solution has not passed all checks (maybe it was only a formatting-check?) and you haven't modified this Pull Request during the last 7 days. It will be automatically closed after the next 7 days if it remains untouched. |
1 similar comment
|
@Vicx95 Your solution has not passed all checks (maybe it was only a formatting-check?) and you haven't modified this Pull Request during the last 7 days. It will be automatically closed after the next 7 days if it remains untouched. |
|
We are closing this PR. If you want to fix your code and get points, please re-open it or raise a new PR |
No description provided.