Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New DataBaseManagment #34

Closed
wants to merge 0 commits into from
Closed

New DataBaseManagment #34

wants to merge 0 commits into from

Conversation

dominikpalatynski
Copy link
Contributor

For now select method is not available
Still To Do: Select Operation, FaultHandling, UT-Tests
For now we can use old DataBaseHandler and I will integrate it later with latest one.

@ziobron ziobron added the Standard The user has Standard course option label Feb 22, 2024
ziobron
ziobron reviewed Feb 29, 2024
View reviewed changes
source/main.cpp Outdated Show resolved Hide resolved
source/DataBase/interface/IQueryOperationBuilder.hpp Outdated Show resolved Hide resolved
source/DataBase/interface/IQueryOperationBuilder.hpp Outdated Show resolved Hide resolved
source/DataBase/common/ITable.hpp Outdated Show resolved Hide resolved
source/DataBase/common/ITable.hpp Outdated Show resolved Hide resolved
source/DataBase/common/DataBaseCommon.hpp Outdated Show resolved Hide resolved
source/DataBase/QueryOperationBuilder.cpp Outdated Show resolved Hide resolved
source/DataBase/QueryOperationBuilder.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseManager.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseConnection.hpp Outdated Show resolved Hide resolved
skwarq
skwarq reviewed Mar 6, 2024
View reviewed changes
source/DataBase/interface/IDataBaseConnection.hpp Outdated Show resolved Hide resolved
source/DataBase/interface/IDataBaseManager.hpp Outdated Show resolved Hide resolved
source/main.cpp Outdated Show resolved Hide resolved
ziobron
ziobron reviewed Mar 7, 2024
View reviewed changes
source/DataBase/DataBaseConnection.hpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseManager.cpp Outdated Show resolved Hide resolved
source/DataBase/QueryOperationBuilder.cpp Outdated Show resolved Hide resolved
source/DataBase/QueryOperationBuilder.cpp Outdated Show resolved Hide resolved
source/DataBase/QueryOperationBuilder.cpp Outdated Show resolved Hide resolved
@skwarq
Copy link
Contributor

skwarq commented Mar 11, 2024

The code looks fine to me, but the commit history is poor. Please squash the commits and rebase to main branch

emttiew
emttiew reviewed Mar 12, 2024
View reviewed changes
source/DataBase/DataBaseConnection.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseConnection.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseManager.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseManager.cpp Outdated Show resolved Hide resolved
source/DataBase/DataBaseManager.cpp Outdated Show resolved Hide resolved
source/test/DataBaseManagerTests.cpp Outdated Show resolved Hide resolved
source/test/DataBaseManagerTests.cpp Outdated Show resolved Hide resolved
source/test/DataBaseManagerTests.cpp Outdated Show resolved Hide resolved
source/test/DataBaseManagerTests.cpp Outdated Show resolved Hide resolved
source/test/DataBaseManagerTests.cpp Outdated Show resolved Hide resolved
@dominikpalatynski dominikpalatynski force-pushed the main branch 4 times, most recently from 64b77f3 to 753d524 Compare March 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skwarq skwarq skwarq left review comments

@emttiew emttiew emttiew left review comments

@ziobron ziobron ziobron left review comments

Assignees
No one assigned
Labels
Standard The user has Standard course option
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikpalatynski @skwarq @ziobron @emttiew