-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tłumaczenie #85
base: main
Are you sure you want to change the base?
Tłumaczenie #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions from me.
|
||
<a href="https://raw.githubusercontent.com/coders-school/object-oriented-programming/master/shm-uml.svg"> | ||
<img height="500" data-src="../shm-uml.svg" src="https://raw.githubusercontent.com/coders-school/object-oriented-programming/master/shm-uml.svg" alt="Diagram klas - SHM" class="plain"> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that either abbrevation should be changed to STS or there should explanation something like |SHM(pol. Symulator handlu morskiego) - Sea Trade Simulator"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, putting polish version should clear things out. Thanks 🙂
module1/01_access_modifiers.en.md
Outdated
|
||
___ | ||
|
||
## Access modifier `protected` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Access modifier `protected` | |
### Access modifier `protected` |
I think it should be sub-paragraph of "Access modifiers"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it matters too much, but I'll add it. Thanks for suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jak dla mnie faktycznie jedyna rzecz to poprawienie kwestii skrótów na ich angielskie odpowiedniki, jak już zostało przez kogoś napisane. Na zasadzie STS - Sea Trade Simulator (pol. SHM - Symulator Handlu Morskiego).
Tyle z moich jakichkolwiek uwag czy zastrzeżeń.
Właśnie za bardzo nie chciałem zmieniać samego skrótu, bo jest on używany także poza tą prezentacją w innych modułach i plikach (np. w repo cmake albo testing w zadaniach). Zobaczymy co jeszcze powie Łukasz @ziobron 🙂. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo everything is OK
Ja powiem, że skrótu nie chcemy zmieniać. Zostaje SHM. Ale samo tłumaczenie będę sprawdzał jeszcze trochę później. Niech dojrzewa :D |
Fixed patern delegate add two function in ship and player class
No description provided.