Skip to content

Commit

Permalink
add placeholder for a 3rd exercise: code review; closes #278
Browse files Browse the repository at this point in the history
  • Loading branch information
bast committed Mar 12, 2024
1 parent c86485a commit 3face80
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 0 deletions.
12 changes: 12 additions & 0 deletions content/code-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Practicing code review

Placeholder for an episode on code review.


## Exercise

We are working on creating an exercise for code review:
- suggest a change
- review a change
- reviewer asks for an improvement
- submitter improves the pull request without having to close and open a new one
5 changes: 5 additions & 0 deletions content/forking-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ Please step out of the repository and check that you fork the **forking**-workfl
```


## Exercise

We are working on combining the steps into one exercise.


## Exercise preparation

``````{prereq} Exercise preparation
Expand Down
1 change: 1 addition & 0 deletions content/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ concepts.md
same-repository.md
forking-workflow.md
contributing.md
code-review.md
```

```{toctree}
Expand Down
5 changes: 5 additions & 0 deletions content/same-repository.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ Real life examples:
- [https://github.com/ropensci/plotly](https://github.com/ropensci/plotly)


## Exercise

We are working on combining the steps into one exercise.


## Exercise preparation

In this exercise we will practice collaborative centralized workflow in
Expand Down

0 comments on commit 3face80

Please sign in to comment.